Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(modal): change the cancel button variant to link #2979

Merged
merged 1 commit into from Sep 25, 2019
Merged

docs(modal): change the cancel button variant to link #2979

merged 1 commit into from Sep 25, 2019

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Sep 20, 2019

What:
closes #2585

Update Modal document to have cancel button as link.

@jschuler is that what you meant?

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2979.surge.sh

@jenny-s51 jenny-s51 self-assigned this Sep 20, 2019
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for @jschuler to confirm

@mcarrano
Copy link
Member

Looks great. Thanks @boaz0 !

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit b9c2068 into patternfly:master Sep 25, 2019
@boaz0 boaz0 deleted the closes_2585 branch April 24, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal: Cancel button should be a LinkButton
5 participants